search

google-marketing-solutions / Tightlock

Apache License 2.0
35 stars 15 forks source link

Fix: error handling cm360OCI #164

Closed giuseppescarciglia closed 7 months ago

giuseppescarciglia commented 7 months ago

There is an issue in the connector with Campaign Manager for the offline conversion import process.

Line 156 in /dags/destinations/cm360oci.py :

"not response.get("hasFailures")" is TRUE even if the response json contains {"hasFailures":"false"}, incorrectly raising the subsequent error: "Sending payload to CM360 did not complete successfully.".

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

caiotomazelli commented 7 months ago

Thanks for catching that and for contributing @giuseppescarciglia!