google-marketing-solutions / crmint

Reliable data integration & processing for advertisers
https://google-marketing-solutions.github.io/crmint/
Other
184 stars 77 forks source link

Conversion Value Calculation Adjustment #471

Closed blackwire closed 1 year ago

blackwire commented 1 year ago

Resolves issue with probabilities for conversion values not matching a segment due to gaps between segment ranges. Sets the floor on the first range to 0 and the ceiling on the last range to 1 to avoid misses this way. Sets the range start and end to the average of the two to avoid gaps between the ranges.

blackwire commented 1 year ago

Hi - in terms of SQL formatting and errors, it looks good and I approve. However, for the sake of transparency, I don't know enough about statistics to understand the changes and vet them for accuracy. Maybe we should ask someone from data science to review?

Thanks, -Julio

This update was created in conjunction with someone from Data Science. Thanks!