google-pay / google-pay-button

Google Pay button - React, Angular, and custom element
Apache License 2.0
247 stars 60 forks source link

issue when set locale in Arabic #251

Closed sajasbana closed 6 months ago

sajasbana commented 9 months ago

Dears, there is issue when gpay button we set locale in Arabic reference link: https://developers.google.com/pay/api/web/guides/resources/customize

it should be like below imaeg image

dmengelt commented 9 months ago

@sajasbana thank you very much for reporting this. we are aware and are looking into it.

ibrahimchiha commented 7 months ago

@dmengelt has this been resolved? Currently facing the same issue

dmengelt commented 7 months ago

@ibrahimchiha unfortunately not yet 😢 will keep you posted...

dmengelt commented 7 months ago

@sajasbana / @ibrahimchiha is the translation only wrong for button type pay or others as well?

sajasbana commented 7 months ago

@dmengelt translation is right but letters are reversed

dmengelt commented 6 months ago

@sajasbana could you check again and let me know if the translations look good to you now?

sajasbana commented 6 months ago

@dmengelt Thanks for your effort it is almost done, but still some buttons have the same issue (pay and subscribe) buttons https://developers.google.com/pay/api/web/guides/resources/customize image

dmengelt commented 6 months ago

@sajasbana can you try to clear your cache and try again. For me it looks different for pay and subscribe:

Google Pay button with button type pay Google Pay button with button type subscribe
sajasbana commented 6 months ago

@dmengelt Thanks it is working we can close this issue

dmengelt commented 6 months ago

Great. Thanks for your help @sajasbana