Closed jocmp closed 9 months ago
@jocmp thanks for reporting this. we will look into it
@jocmp is there a way for you to do a simple reproducer on something like stackblizt.com?
@dmengelt Sure thing. Here's a reproduction of the data Reverb sends to the Google Pay button: https://stackblitz.com/edit/react-ts-9tm2tr. The demo works for me on both Chrome and Firefox for the Test environment.
Firefox screenshot
I discovered that this issue is not based on environment. The "To make this purchase..." error also appears on Firefox for Test and Production reverb.com environments. I was able to reproduce that on Reverb's public sandbox site - https://sandbox.reverb.com - which is a test environment for Google Pay and uses an Adyen Test environment as well for payment processing. A full video of that is shown below for Firefox and Chrome.
Firefox (does not work for Test or Production)
https://github.com/google-pay/google-pay-button/assets/9521010/efb2ceeb-178b-4805-9f94-26e0e6b30d2c
Chrome (works in all environments)
https://github.com/google-pay/google-pay-button/assets/9521010/aad1fbef-f2b0-4956-bc10-5c67339bdad8
Firefox works for me in the Test environment so long as the domain does not fall under reverb.com
.
I have two questions
Let me know what you think!
Ah yeah I meant a reproducer to see the "To make this purchase..." error 😉 Your stackblitz demo works on all browsers for me.
To answer your two questions:
We will continue investigating.
hey @dmengelt - just checking to see if you've found anything. We're still experiencing this issue.
We are suspecting having react router for checkout is causing the hosting page to be treated as redirect instead of "pop-up" on our side. We are still investigating though.
@jocmp for some reason window.opener
is not defined for reverb.com. We use this property to detect if we can go "pop-up" mode.
@jocmp could you try to remove rel='noopener'
for your payment method form and let me know if the behaviour changes?
Thanks @dmengelt, the opener policy was the key. Reverb had a Cross-Origin-Opener-Policy set to "same-origin"
to prevent cross-site attacks. Changing this to "same-origin-allow-popups"
resolved the issue for Firefox and Safari.
Describe the bug A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:
Notes:
Expected behavior: The browser pop-up works as with other eComm sites like etsy.com
Screenshots
Component information:
@google-pay/button-react
)@google-pay/button-element
)@google-pay/button-angular
)