google-pay / google-pay-button

Google Pay button - React, Angular, and custom element
Apache License 2.0
246 stars 60 forks source link

set allowCreditCards to false has UI defect and will block all test cards #291

Open chrisudf opened 2 months ago

chrisudf commented 2 months ago

Describe the bug A clear and concise description of what the bug is.

Hello 👋 , not sure if this's the best repo to ask but I can reproduce the error via the Jsfiddle link from your site. https://jsfiddle.net/ru59csa1/

when disabling credit card by setting allowCreditCards parameters to false it blocked all test cards and the UI is broken. can only use real cards to test.

Happens in JS also for the Android Sdk (the UI is ok tho, just test cards not usable).

To Reproduce Steps to reproduce the behavior:

  1. Go to the sandbox
  2. Change allowCreditCards to false for parameters in baseCardPaymentMethod
  3. Run the code then click the pay button
  4. test cards are blocked and the UI styling is off
  5. can only test via real cards, setting this boolean to false can block my real credit card and still allow real debit card

JsFiddle link https://jsfiddle.net/ru59csa1/

Expected behavior A clear and concise description of what you expected to happen. Any chance you can fix the UI, fix/provide extra cards to test ban credit card?

Screenshots If applicable, add screenshots to help explain your problem. image

working as expected when testing with real cards, the last one is a credit card and it's blocked image

Component information:

Environment:

Additional context Add any other context about the problem here.

dmengelt commented 1 month ago

@chrisudf thanks for reporting this! we are looking into it...