Closed jinlinyi closed 3 years ago
Thanks for the PR. Looks great. I couldn't leave comments on the notebook, so I'll leave them here:
For the functionn project_by_intrinsics, you are passing example
in the function API but you are using the element
in the function body. Make sure you are passing the element to the function, so each function does not have any dependency on the state of the notebook.
Oops, good catch!
LGTM, thanks
Just an FYI but after talking to my labmate Linyi (@jinlinyi) we realized that the three functions project_by_point2d
, project_by_intrinsics
, and project_by_camera_projection
all produce slightly different results
Solving issue https://github.com/google-research-datasets/Objectron/issues/14