google-research / CVD-paper-mobile-camera-example

Apache License 2.0
6 stars 4 forks source link

Need API for Status Access at activity level for UploadRequest #47

Closed khyativyasargus closed 6 months ago

khyativyasargus commented 7 months ago

We will need API to have access to the status from UploadRequest at the activity level, so we can handle UI block till Upload is processed successfully and also handle the failure case.

@MJ1998

MJ1998 commented 7 months ago

Why do you need to block UI while uploading?

Also do you need access to uploadrequest based on resourceInfoId (for example yoy know PPG resource is collected and has a resourceInfoId) OR the current uploadrequest based on status( for example status=UPLOADING for the current upload being processed)?

If you need the latter then you will get List of UploadRequests with current status as UPLOADING which you can use to show on the UI or as some app notification

khyativyasargus commented 7 months ago

Why do you need to block UI while uploading?

Also do you need access to uploadrequest based on resourceInfoId (for example yoy know PPG resource is collected and has a resourceInfoId) OR the current uploadrequest based on status( for example status=UPLOADING for the current upload being processed)?

If you need the latter then you will get List of UploadRequests with current status as UPLOADING which you can use to show on the UI or as some app notification

In order to make sure the user doesn't close the app before data is uploaded successfully. We already have sync feature where we sync another data blocking UI with progressbar, so can include this Uploading as well as single upload thread for both.

Also we will only need it based on status.

MJ1998 commented 7 months ago

I am not sure why user needs to keep the app open while uploading.

Even if user needs to, showing a non-blocking UI is preferred over blocking UI to show progress update.