google-research / FirstOrderLp.jl

Experimental first-order solvers for linear and quadratic programming.
Apache License 2.0
103 stars 19 forks source link

Remove 'cd' from benchmarking/collect_lp_benchmark.sh #79

Closed dapplegate closed 3 years ago

dapplegate commented 3 years ago

benchmarking/collect_lp_benchmark.sh changed it's working directory to the temporary directory before collecting and extracting instances. This would break if the destination directory was given as a relative path instead of an absolute path. This changes the script to drop the "cd", and instead specify the temporary directory explicitly in the place where the current working directory was being used.

An alternative would be to try to expand the destination directory into an absolute path, but this can be a bit tricky to get right.

Tested by running manually.