google-research / FirstOrderLp.jl

Experimental first-order solvers for linear and quadratic programming.
Apache License 2.0
103 stars 19 forks source link

Add best per instance scaling to scaling results #86

Closed bodono closed 3 years ago

bodono commented 3 years ago

Update the scaling plots to show best on a per-instance basis.

bodono commented 3 years ago

Btw, if we merge this then the figures produced by the script will no longer match the paper we submitted. We should decide if we want to change the paper figs, or if we don't want this change at all in the main script, or we do want it, but we want the original paper figs as well (would need to update the script for that).

dapplegate commented 3 years ago

Btw, if we merge this then the figures produced by the script will no longer match the paper we submitted. We should decide if we want to change the paper figs, or if we don't want this change at all in the main script, or we do want it, but we want the original paper figs as well (would need to update the script for that).

Oops, I missed that. I think that at least for now, we should make sure we still generate the plots in the paper, so please update the script to keep the old plots as well as generate the new one.

bodono commented 3 years ago

Updated to generate original figs / tables under original names and new figs / tables under new names.