google-research / albert

ALBERT: A Lite BERT for Self-supervised Learning of Language Representations
Apache License 2.0
3.23k stars 571 forks source link

Improvement to how the `app` and `pages` files conflict is shown. Especially the last log line `"pages/" - "app/"` made it seem like you should remove the `pages` folder altogether. This was a bug in how the `''` case was displayed. After having a look at this I went further and added exactly which file caused the conflict given that `app` allows you to create `app/(home)/page.js` and such it saves some digging for what the actual conflicting file is. Similarly in `pages` both `pages/dashboard/index.js` and `pages/dashboard.js` are possible. #270

Closed albrtkinn closed 1 year ago

albrtkinn commented 1 year ago

Improvement to how the app and pages files conflict is shown. Especially the last log line "pages/" - "app/" made it seem like you should remove the pages folder altogether. This was a bug in how the '' case was displayed. After having a look at this I went further and added exactly which file caused the conflict given that app allows you to create app/(home)/page.js and such it saves some digging for what the actual conflicting file is. Similarly in pages both pages/dashboard/index.js and pages/dashboard.js are possible.

Before:

error - Conflicting app and page files were found, please remove the conflicting files to continue:
error -   "pages/another" - "app/another"
error -   "pages/hello" - "app/hello"
error -   "pages/" - "app/"

After:

error - Conflicting app and page files were found, please remove the conflicting files to continue:
error -   "pages/another.js" - "app/another/page.js"
error -   "pages/index.js" - "app/page.js"
error -   "pages/hello.js" - "app/hello/page.js"

Bug

Feature

Documentation / Examples

Originally posted by @timneutkens in https://github.com/vercel/next.js/pull/42415