ALBERT: A Lite BERT for Self-supervised Learning of Language Representations
Apache License 2.0
3.23k
stars
571
forks
source link
Improvement to how the `app` and `pages` files conflict is shown. Especially the last log line `"pages/" - "app/"` made it seem like you should remove the `pages` folder altogether. This was a bug in how the `''` case was displayed. After having a look at this I went further and added exactly which file caused the conflict given that `app` allows you to create `app/(home)/page.js` and such it saves some digging for what the actual conflicting file is. Similarly in `pages` both `pages/dashboard/index.js` and `pages/dashboard.js` are possible. #270
Improvement to how the app and pages files conflict is shown. Especially the last log line "pages/" - "app/" made it seem like you should remove the pages folder altogether. This was a bug in how the '' case was displayed. After having a look at this I went further and added exactly which file caused the conflict given that app allows you to create app/(home)/page.js and such it saves some digging for what the actual conflicting file is. Similarly in pages both pages/dashboard/index.js and pages/dashboard.js are possible.
Before:
error - Conflicting app and page files were found, please remove the conflicting files to continue:
error - "pages/another" - "app/another"
error - "pages/hello" - "app/hello"
error - "pages/" - "app/"
After:
error - Conflicting app and page files were found, please remove the conflicting files to continue:
error - "pages/another.js" - "app/another/page.js"
error - "pages/index.js" - "app/page.js"
error - "pages/hello.js" - "app/hello/page.js"
Bug
[x] Related issues linked using fixes #number
[x] Integration tests added
[x] Errors have a helpful link attached, see contributing.md
Feature
[x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
[x] Related issues linked using fixes #number
[ ] Integration tests added
[ ] Documentation added
[ ] Telemetry added. In case of a feature if it's used or not.
[x] Errors have a helpful link attached, see contributing.md
Documentation / Examples
[ ] Make sure the linting passes by running pnpm build && pnpm lint
Improvement to how the
app
andpages
files conflict is shown. Especially the last log line"pages/" - "app/"
made it seem like you should remove thepages
folder altogether. This was a bug in how the''
case was displayed. After having a look at this I went further and added exactly which file caused the conflict given thatapp
allows you to createapp/(home)/page.js
and such it saves some digging for what the actual conflicting file is. Similarly inpages
bothpages/dashboard/index.js
andpages/dashboard.js
are possible.Before:
After:
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
pnpm build && pnpm lint
Originally posted by @timneutkens in https://github.com/vercel/next.js/pull/42415