google-research / dads

Code for 'Dynamics-Aware Unsupervised Discovery of Skills' (DADS). Enables skill discovery without supervision, which can be combined with model-based control.
Apache License 2.0
186 stars 51 forks source link

Use of skill_discriminator.py #5

Closed maridia closed 4 years ago

maridia commented 4 years ago

Hi,

Is the SkilDiscriminator class used at all in this project? I can't find where it is ever called.

Thanks.

architsharma97 commented 4 years ago

You can use it to construct different reward function, but it is not necessary for reproducing DADS.

maridia commented 4 years ago

Hi Archit,

Thanks for your quick reply. From looking at the reward function, I'm guessing you mostly used it for reproducing the DIAYN results?

architsharma97 commented 4 years ago

Yes! But, there would be subtle differences from the open-sourced version of DIAYN if you choose to use the skill-discriminator from this codebase.