It was quadratic, because it would recompute the free variables of the rest of the block at every decl. Now it doesn't do that, using the same free variables trick that DCE uses for the same purpose.
On the BFGS example, this speeds up occurrence analysis itself by 60-70%, and (according to the profiler) is worth something like a 7% improvement to compilation time end-to-end.
The implementation was a little subtle because I had to make sure that the Access map's keys were exactly the free variables, without extras. Before this, extras were ok, because names were just looked up in there, but now the absence of a name is also meaningful, so has to be correct.
It was quadratic, because it would recompute the free variables of the rest of the block at every decl. Now it doesn't do that, using the same free variables trick that DCE uses for the same purpose.
On the BFGS example, this speeds up occurrence analysis itself by 60-70%, and (according to the profiler) is worth something like a 7% improvement to compilation time end-to-end.
The implementation was a little subtle because I had to make sure that the
Accessmap's keys were exactly the free variables, without extras. Before this, extras were ok, because names were just looked up in there, but now the absence of a name is also meaningful, so has to be correct.