Fix debug build by adding a missing conditional import

google-research / dex-lang

Research language for array processing in the Haskell/ML family

BSD 3-Clause "New" or "Revised" License

1.56k stars 106 forks source link

Fix debug build by adding a missing conditional import #1343

Open ararslan opened 6 months ago

ararslan commented 6 months ago

src/lib/Err.hs conditionally uses unsafePerfomIO when DEX_DEBUG is defined, but it doesn't import System.IO.Unsafe, so unsafePerformIO is not defined. This can be fixed by importing that module when DEX_DEBUG is defined.

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ararslan commented 6 months ago

I keep getting a server error every time I try to sign the CLA. 🤔 Perhaps it'll work eventually.

EDIT: All good now

ararslan commented 1 month ago

@dougalm, I think this PR will fix CI, which is currently red on main. I believe CI is failing on main because setting DEX_CI enables DEX_DEBUG, which is broken without this change.