Potential issue with FactorVAE discriminator loss

google-research / disentanglement_lib

disentanglement_lib is an open-source library for research on learning disentangled representations.

Apache License 2.0

1.38k stars 205 forks source link

Potential issue with FactorVAE discriminator loss #16

Closed psoulos closed 5 years ago

psoulos commented 5 years ago

Hello,

I am writing about the discrimnator loss for FactorVAE. Should the two values in discr_loss be negative? It seems like the probs_z[:, 0] is the probability that the sample comes from the joint distribution, but the line that I linked would encourage the values in probs_z[:, 0] to go towards 0 instead of 1.

psoulos commented 5 years ago

Sorry, I just realized that -discr_loss is minimized instead of discr_loss