modified_dmlab patch missing

google-research / episodic-curiosity

Tensorflow/Keras code and trained models for Episodic Curiosity Through Reachability

Apache License 2.0

195 stars 34 forks source link

modified_dmlab patch missing #10

Open gary1346aa opened 3 years ago

gary1346aa commented 3 years ago

Hello,

I'm trying to build the modified DMLab, but when I apply the modified patch, it says "no such file or directory"

seems that the patch doesn't exist anymore, can you re-upload it again? thanks!

RaphaelMarinier commented 3 years ago

The path is there: https://github.com/google-research/episodic-curiosity/blob/master/third_party/dmlab/dmlab_min_goal_distance.patch

Maybe you tried the wrong command to apply it? Maybe you could describe the steps you performed to apply it?

gary1346aa commented 3 years ago

I deleted and followed the steps again, now it shows other error, here's a screenshot of the steps I performed:

GittiHab commented 2 years ago

I could successfully apply the path by following the instructions in the readme:

git clone https://github.com/deepmind/lab
cd lab
git checkout 7b851dcbf6171fa184bf8a25bf2c87fe6d3f5380
git checkout -b modified_dmlab
git apply ../third_party/dmlab/dmlab_min_goal_distance.patch

Installing it as a pip module was a bit tricky though.

GittiHab commented 2 years ago

Looking at your error log, I would recommend that you simply start the installation from a clean clone. So delete your lab directory and then run all the steps again.

GittiHab commented 2 years ago

I also made a more detailed instruction on how to build the DM Lab module since I ran into a few issues there. Maybe this also helps others. I posted it over in the DM Lab repo.