google-research / multinerf

A Code Release for Mip-NeRF 360, Ref-NeRF, and RawNeRF
Apache License 2.0
3.62k stars 341 forks source link

Update pycolmap documentation from rmbrualla to trueprice. #118

Open humberthardy opened 1 year ago

humberthardy commented 1 year ago

In the documentation, it is mentioned that we can use fisheye camera model, but you probably forgot to mention that we should use another version of pycolmap, trueprice, because:

  1. rmbrualla does not support OPENCV_FISHEYE camera model
  2. rmbrualla's commits has been already merged to trueprice (-rmbrualla is a fork of trueprice-)

    Tip for testers: do not forgot to update the Config.near if you are using a fisheye camera ;)

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hecodeit commented 1 year ago

In the documentation, it is mentioned that we can use fisheye camera model, but you probably forgot to mention that we should use another version of pycolmap, trueprice, because:

  1. rmbrualla does not support OPENCV_FISHEYE camera model
  2. rmbrualla's commits has been already merged to trueprice (-rmbrualla is a fork of trueprice-)

    Tip for testers: do not forgot to update the Config.near if you are using a fisheye camera ;)

@humberthardy If using OPENCV_FISHEYE, what's the value of Config.near should setting?

humberthardy commented 1 year ago

@hecodeit: I notice we had a kind of "sphere removal" with fisheye around the camera (like the teleporter in terminator). My pictures were not blurred, so I used a value close to 0 (0.001 if I remember well)

humberthardy commented 1 year ago

@hecodeit: I notice we had a kind of "sphere removal" with fisheye around the camera (like the teleporter in terminator). My pictures were not blurred, so I used a value close to 0 (0.001 if I remember well)

hecodeit commented 1 year ago

Thanks @humberthardy, I'll try 0.001

I notice NerfStudio most dataset use fisheye lens, and the near plan setting using 0.05, maybe try 0.05 both.