search

google-research / multinerf

A Code Release for Mip-NeRF 360, Ref-NeRF, and RawNeRF
Apache License 2.0
3.58k stars 339 forks source link

Inconsistent usage of direction and viewdir in gaussian mean computation and in rendering alpha computation #58

Closed hbgtjxzbbx closed 1 year ago

hbgtjxzbbx commented 1 year ago

Thanks for the great work and the repository. When I read the code, i find there is a confusing usage of direction and its normalized version viewdirs. when compute guassian mean, the direction is used https://github.com/google-research/multinerf/blob/175b529c0889d5e85b914f97d66345ab56087ee0/internal/render.py#L21 but when compute intervals between sampling points, viewdirs is used https://github.com/google-research/multinerf/blob/175b529c0889d5e85b914f97d66345ab56087ee0/internal/render.py#L133

should they be consistent in these two places? Thanks

hbgtjxzbbx commented 1 year ago

Oh, sorry, they are consistent.