search

google-research / pix2seq

Pix2Seq codebase: multi-tasks with generative modeling (autoregressive and diffusion)
Apache License 2.0
857 stars 71 forks source link

Versions of libraries in the requirements.txt #22

Open xwjabc opened 1 year ago

xwjabc commented 1 year ago

Hi, I would like to know if the versions of libraries in the requirements.txt can be provided. Currently I am using the latest TF (2.11) that seems to have breaking change in the optimizer. Thus, the initialization for base class in AdamWeightDecay() (https://github.com/google-research/pix2seq/blob/main/models/model_utils.py#L104) has incorrect arguments compared to the corresponding ones in https://github.com/keras-team/keras/blob/v2.11.0/keras/optimizers/optimizer_experimental/adam.py#L86. Thanks!

chentingpc commented 1 year ago

I think the code should be compatible with latest (stable) version of tensorflow. AdamWeightDecay is a subclass of the default Adam optimizer in keras, so it is fine to have different input arguments for AdamWeightDecay as long as that for Adam is consistent (which it is).