search

google-research / recsim

A Configurable Recommender Systems Simulation Platform
https://github.com/google-research/recsim
Apache License 2.0
732 stars 127 forks source link

Bug in slate_decomp_q_agent #26

Open rahul-zomato opened 1 year ago

rahul-zomato commented 1 year ago

self._replay_next_target_net_outputs = self._network_adapter( self._replay.states, 'Target')

should be

self._replay_next_target_net_outputs = self._network_adapter( self._replay.next_states, 'Target')

at https://github.com/google-research/recsim/blob/master/recsim/agents/slate_decomp_q_agent.py#L518

rahul-zomato commented 1 year ago

@cwhsu-google

abhiishek-pal commented 1 year ago

Thanks @rahul-zomato was about to totally skip over this bug.