google-research / tapas

End-to-end neural table-text understanding models.
Apache License 2.0
1.13k stars 216 forks source link

missing annotated_text_pb2 #142

Closed g1644222 closed 2 years ago

g1644222 commented 2 years ago

Thank you for your interesting research.

I am working along with Installation now. I am getting an ImportError in the tox section.

スクリーンショット

from protos import annotated_text_pb2 ImportError: cannot import name 'annotated_text_pb2'

eisenjulian commented 2 years ago

Hello, the corresponding file annotated_text.proto is present in the tapas/proto folder, so this leads me to believe that the proto file was not compiled successfully, can you check for earlier errors in your run, perhaps the protoc compiler wasn't found?

Otherwise if you can provide a colab to reproduce the error it would help a lot,

Cheers!

g1644222 commented 2 years ago

Thank you for the quick response.

I was getting another error before this one. It was pip install -e . error occurred.

エラーログ2

This error could be avoided by removing annotated_text_pb2. Was that a bad idea?

eisenjulian commented 2 years ago

Yes, a bad idea, it seems that there's an issue with old versions of protoc. Can you confirm by running protoc --version?

Please try to update to a version >= 3 and try installing again.

Context: https://stackoverflow.com/questions/50241452/using-maps-in-protobuf-v2

g1644222 commented 2 years ago

@eisenjulian You made a good point! I checked the version of protoc and it's 2.6.1

By raising the version to 3, I was able to successfully generate annotated_text_pb2.

Thanks for your help!