google-research / tapas

End-to-end neural table-text understanding models.
Apache License 2.0
1.13k stars 216 forks source link

ValueError: Unknown task: HYBRIDQA #150

Closed leezythu closed 2 years ago

leezythu commented 2 years ago

When I tried to fine-tune on HYBRIDQA task, the function 'get_train_filename' in task_utils.py raised this error. Is it normal? Or you haven't implemented fine-tuning HYBRIDQA fully.

leezythu commented 2 years ago

If not, will you release the code for HYBRIDQA ?

eisenjulian commented 2 years ago

Hello @leezythu thanks for your question, I just updated the code with the missing changes. Let me know if you run into any other problems, please consider than unlike other datasets, HybridQA requires training both cell selection model (with task name HYBRIDQA) and a reader model (with task name HYBRIDQA_RC)

leezythu commented 2 years ago

@eisenjulian Thanks for your kind response, and it helps me a lot! Now I have gotten tfrecord files for HYBRIDQA, but I run into another problem. I find that the function '_train_and_predict' and '_predict' in run_task_main.py don't include codes for HYBRIDQA. So which file do I need to run to train HYBRIDQA model and HYBRIDQA_RC model? Is it tapas_classifier_experiment.py? I would appreciate it if you could explain it.

eisenjulian commented 2 years ago

You're correct, I've updated those functions to consider HYBRIDQA and HYBRIDQA_RC the datasets as well