Open w-e-w opened 1 month ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
CLA... just treat this as an issue post
I'm pretty sure that "fix" actually broke this repo as a module
I belive the error
ImportError: attempted relative import with no known parent package
occurs if people try to runsrc/timesfm.py
directly and they might have reason to do so because this reop did not work as a module on it's initial releaseadding to this this repo is structured weirdly so people might be confused on how they should be using this repo and running the code
timeline
fix code structure
https://github.com/google-research/timesfm/commit/24bd19c74bd6b28eb576437f21b22b20f6536520 this repo only works under several conditions so people migh comewith diffrent creative ways ways of running the codefix code structure
https://github.com/google-research/timesfm/commit/24bd19c74bd6b28eb576437f21b22b20f6536520 made this reop worked as a module but breaks running itdirectlythe reason I don't perform the restructure myself in this PR is because a the restructure of the project would cause existing users to have issues, my intention is to only get back to a code working state