search

google-research / torchsde

Differentiable SDE solvers with GPU support and efficient sensitivity analysis.
Apache License 2.0
1.51k stars 194 forks source link

Fix incorrectly formatted version rules #133

Closed jphan32 closed 10 months ago

jphan32 commented 11 months ago

Related issue number

Description

Fix incorrectly formatted version rules.

jphan32 commented 10 months ago

Could someone please review my PR? Thank you.

jphan32 commented 10 months ago

Hello maintainers,

I recently submitted a pull request and noticed that there was a build error during the review process. Upon inspecting the error message, it was related to the install_requires section in the setup.py file. Specifically, the error message was:

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [3 lines of output]
      error in torchsde setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; .* suffix can only be used with `==` or `!=` operators
          numpy>=1.19.*;python_version>='3.7'
               ~~~~~~~^
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

To address this, I updated the requirement string from numpy>=1.19.*;python_version>='3.7' to numpy>=1.19;python_version>='3.7' and committed the changes. However, the build test still seems to produce the same error message indicating the presence of the older code.

Could you please help me understand why this might be happening? Is there something I may have missed or another step I need to take to ensure the updates are reflected?

Thank you for your assistance!

patrick-kidger commented 10 months ago

Ah, that's because it's pulling from the GitHub main branch to do a version check. Let me poke at that.

FWIW you may note that torchsde hasn't been touched in a couple of years; I'll try to get this PR merged, but I'd recommend Diffrax for new projects.

lxuechen commented 10 months ago

@patrick-kidger I enabled force push for you. Can you check if you can force merge?

lxuechen commented 10 months ago

@patrick-kidger I enabled force push for you. Can you check if you can force merge?

Merged and thanks, @jphan32. Let me know what else I should help with.

jphan32 commented 10 months ago

I've confirmed that my PR has been successfully merged into the master branch. Thank you. Also, I appreciate the introduction to Diffrax.