search

google-research / tuning_playbook

A playbook for systematically maximizing the performance of deep learning models.
Other
26.35k stars 2.2k forks source link

Typo: Missing parenthesis in nesterov momentum #7

Closed dsuedholt closed 5 months ago

dsuedholt commented 1 year ago

FAQs -> What are the update rules for all the popular optimization algorithms? -> Nesterov

A closing parenthesis is missing in the third equation. It's currently

$$\theta{t+1} = \theta{t} - \etat( \gamma v{t+1} + \nabla \mathcal{l}(\theta_{t})$$

and should be

$$\theta{t+1} = \theta{t} - \etat( \gamma v{t+1} + \nabla \mathcal{l}(\theta_{t}))$$

JatinKumar001 commented 1 year ago

Hey, can I work on this typo?

varungodbole commented 1 year ago

Thanks for pointing this out! Please feel free to send me a pull request.

varungodbole commented 5 months ago

I think @znado just merged the PR to fix this. Closing this issue for now.