google-research / uda

Unsupervised Data Augmentation (UDA)
https://arxiv.org/abs/1904.12848
Apache License 2.0
2.17k stars 312 forks source link

Python 2? Really? #8

Open impredicative opened 5 years ago

impredicative commented 5 years ago

The code is tested on Python 2.7 and Tensorflow 1.13.

Why use Python 2 for this and not Python 3? Python 2 is less than six months away from expiration. No one prefers to use Python 2 anymore.

michaelpulsewidth commented 5 years ago

The text part of the code should be compatible with both python 2 and python 3, since BERT works for both. For the vision part, we used python 2 since AutoAugment was originally written in python 2.7. See this issue https://github.com/tensorflow/models/issues/6144

Ritali commented 4 years ago

There are some errors with py3, such as unicode and another differences between py2 and py3, have to find and fix them first.

sshleifer commented 4 years ago

More specifically, trying text/scripts/prepro.sh with py3 results in TypeError: can't concat str to bytes from load_vocab. Are you guys considering updating to py3?