search

google-wallet / passes-rest-samples

Server-side samples for the Google Pay API for Passes
Apache License 2.0
95 stars 49 forks source link

Missing items from C# Library mentioned in samples #16

Closed faceoffers28 closed 5 years ago

faceoffers28 commented 5 years ago

There appears to be some missing items in the C# Library found here.

Both OfferClass and OfferObject is missing IssuerData. Perhaps this is an oversight or perhaps this is on purpose. The documentation shows IssuerData, so I assume it's an oversight.

Hope this helps.

angelbarranco commented 5 years ago

Offer objects and classes are linked to an issuer through an id field.

Is this what you are referring to?

faceoffers28 commented 5 years ago

Perhaps. issuerData is mentioned in the documentation for both the OfferClass and the OfferObject as shown here. https://developers.google.com/pay/passes/guides/pass-verticals/offers/code-snippets#json-offerclass

IssuerData is not found in the C# Library for OfferClass and OfferObject.

angelbarranco commented 5 years ago

The field is deprecated. Let me update the docs. Thanks for bringing this up.