google / AEUX

Editable After Effects layers from Sketch artboards
Apache License 2.0
502 stars 55 forks source link

AEUX unable to handle stroke per sides from Figma #184

Open waltercoots opened 11 months ago

waltercoots commented 11 months ago

Describe the bug On Figma frames and rectangles which have strokes applied to 1–3 sides, AEUX throws an error when an import is attempted.

To Reproduce Steps to reproduce the behavior:

  1. Ensure Adobe After Effects and Figma are both open, configured properly, and that AEUX communicates normally
  2. Select a frame in Figma
  3. Apply a stroke to left, right, top, or bottom (but not all sides)
  4. Open AEUX from the Plugins menu > Development > AEUX
  5. Click the "Send selection to Ae" button
  6. Error appears in Adobe After Effects: Error: After Effects error: Unable to call "setValue" because of parameter 1. Value is undefined. Error on line: 979

Expected behavior AEUX should import the frame, and one of the two following should happen:

  1. Lower effort. No stroke is applied, or strokes appear on all sides.
  2. Higher effort: Dash and Offset properties are calculated and applied to mimic the stroke from Figma

Screenshots Value Undefined Figma Setup

Desktop (please complete the following information):

Additional context A complex layout with many nested layers was throwing the error for me, so I narrowed this down by trial and error. I realize it's been about a year since updates have been made, but I thought I'd submit in case anyone else is having issues and might benefit from knowing this could be the cause. Thanks for all the hard work on this! Hope to see it updated.

vmedium commented 11 months ago

No development being done on this, so I don't think we're going to see this improvement.

On Wed, Aug 9, 2023 at 6:59 PM Walter Coots @.***> wrote:

Describe the bug On Figma frames and rectangles which have strokes applied to 1–3 sides, AEUX throws an error when an import is attempted.

To Reproduce Steps to reproduce the behavior:

  1. Ensure Adobe After Effects and Figma are both open, configured properly, and that AEUX communicates normally
  2. Select a frame in Figma
  3. Apply a stroke to left, right, top, or bottom (but not all sides)
  4. Open AEUX from the Plugins menu > Development > AEUX
  5. Click the "Send selection to Ae" button
  6. Error appears in Adobe After Effects: Error: After Effects error: Unable to call "setValue" because of parameter 1. Value is undefined. Error on line: 979

Expected behavior AEUX should import the frame, and one of the two following should happen:

  1. Lower effort. No stroke is applied, or strokes appear on all sides.
  2. Higher effort: Dash and Offset properties are calculated and applied to mimic the stroke from Figma

Screenshots [image: Value Undefined] https://user-images.githubusercontent.com/3695381/259594209-61b39f3e-f553-405d-aa64-11f08c556aab.png [image: Figma Setup] https://user-images.githubusercontent.com/3695381/259594389-14617ee8-87f7-4129-aa45-be3fba1a553e.png

Desktop (please complete the following information):

  • AEUX 0.8.2
  • macOS Ventura Version 13.5 (22G74)
  • Figma Desktop App version 116.11.1 (Apple Silicon)
  • After Effects 23.5.0 Build 52

Additional context A complex layout with many nested layers was throwing the error for me, so I narrowed this down by trial and error. I realize it's been about a year since updates have been made, but I thought I'd submit in case anyone else is having issues and might benefit from knowing this could be the cause. Thanks for all the hard work on this! Hope to see it updated.

— Reply to this email directly, view it on GitHub https://github.com/google/AEUX/issues/184, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALNXMZOTBGVU4JKWBPJNVDXUQ573ANCNFSM6AAAAAA3KZNYTE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

adithayyil commented 3 months ago

Will this ever get fixed?? 🥲