search

google / CFU-Playground

Want a faster ML processor? Do it yourself! -- A framework for playing with custom opcodes to accelerate TensorFlow Lite for Microcontrollers (TFLM). . . . . . Online tutorial: https://google.github.io/CFU-Playground/ For reference docs, see the link below.
http://cfu-playground.rtfd.io/
Apache License 2.0
463 stars 117 forks source link

(CFU Playground) Automatic Renode update from builds.renode.io #746

Closed cfu-playground-bot closed 1 year ago

cfu-playground-bot commented 1 year ago

(CFU Playground) Automatic Renode update from builds.renode.io

tcal-x commented 1 year ago

@PiotrZierhoffer I'm seeing this in the failing tests --- some upstream change in Renode?

/home/runner/work/CFU-Playground/CFU-Playground/third_party/renode/verilator-integration-library/src/buses/cfu.cpp:24:77: error: ‘DEFAULT_TIMEOUT’ was not declared in this scope
   24 | void Cfu::timeoutTick(uint8_t* signal, uint8_t expectedValue, int timeout = DEFAULT_TIMEOUT)
      |                                                                             ^~~~~~~~~~~~~~~
make[4]: *** [CMakeFiles/libVtop.dir/build.make:112: CMakeFiles/libVtop.dir/home/runner/work/CFU-Playground/CFU-Playground/third_party/renode/verilator-integration-library/src/buses/cfu.cpp.o] Error 1
PiotrZierhoffer commented 1 year ago

That's correct, there was a change upstream. I will verify why does it break for you

PiotrZierhoffer commented 1 year ago

It was an omission on our side. Fixed on master, it should be propagated to our nightly build soon.

PiotrZierhoffer commented 1 year ago

The current fail is quite surprising. We'll investigate it further

tcal-x commented 1 year ago

The current fail is quite surprising. We'll investigate it further

Thanks Piotr!

tcal-x commented 1 year ago

@PiotrZierhoffer it seems Renode tests have been failing for a while even on mainline. If you go to the actions page for "Test projects" https://github.com/google/CFU-Playground/actions/workflows/test-projects.yml , it looks like they pass, but that's just the matrix generation -- the individual tests are failing, like here -- https://github.com/google/CFU-Playground/actions/runs/3709683049.

On main branch, I did a make renode in my sandbox (using proj/mnv2_first/) and it worked (Renode, version 1.13.1.2558 (214e6771-202209210125)), but then I updated Renode to renode-1.13.2+20221201git41d77336 and now see this:

[ 11%] Building CXX object CMakeFiles/libVtop.dir/sim_main.cpp.o
In file included from /media/tim/GIT/clean/CFU-Playground/third_party/renode/verilator-integration-library/src/renode_cfu.h:11,
                 from /media/tim/GIT/clean/CFU-Playground/common/renode-verilator-integration/sim_main.cpp:25:
/media/tim/GIT/clean/CFU-Playground/third_party/renode/verilator-integration-library/src/buses/cfu.h:10:10: fatal error: bus.h: No such file or directory
   10 | #include "bus.h"
      |          ^~~~~~~
compilation terminated.
PiotrZierhoffer commented 1 year ago

It's quite interesting - the problem with the old tests failing is that we fetch renode-verilator-integration library from Renode's master instead of the correct commit. So it's actually unrelated to bumping Renode

PiotrZierhoffer commented 1 year ago

Addressed both issues in #749