Open stucash opened 3 years ago
Can you provide a function call that leads to the crash? I can't reproduce a crash.
Tested:
library(CausalImpact)
test_data <- read.table("spce.csv", sep = ",", header = TRUE)
fin.ci(dat, "2021-05-28", period = "daily")
This works.
Note that the function fin.ci()
itself produces an error if period
is different from "daily"
because the variable extend
(argument to ifelse()
) is not defined.
Can you provide a function call that leads to the crash? I can't reproduce a crash.
Tested:
library(CausalImpact) test_data <- read.table("spce.csv", sep = ",", header = TRUE) fin.ci(dat, "2021-05-28", period = "daily")
This works.
Note that the function
fin.ci()
itself produces an error ifperiod
is different from"daily"
because the variableextend
(argument toifelse()
) is not defined.
I have edited the function sorry I thought extend
was irrelevant; I added it back now in the function signature.
The call that led to crash was just that plot(res)
.
I am experiencing crash with ggplot2
now as well; my gut feeling is that I might have messed up some base R
plotting libraries (which is highly unlikely though......)? I am not sure whether this is a valid issue for this package any more. If you guys can't reproduce it in any environment it should be a safe close.
I have edited the function sorry I thought
extend
was irrelevant; I added it back now in the function signature.
Thanks.
The call that led to crash was just that
plot(res)
.
I meant, what call of fun.ci()
crashes? Which arguments do you have to provide to fun.ci()
to cause the crash in plot(res)
within that function?
I am experiencing crash with
ggplot2
now as well; my gut feeling is that I might have messed up some baseR
plotting libraries (which is highly unlikely though......)? I am not sure whether this is a valid issue for this package any more. If you guys can't reproduce it in any environment it should be a safe close.
OK. Maybe try updating all packages to the latest version and see if the error persists.
I was commenting under another crash related issue but found out mine eventually was a different story.
I am running
R 4.1
inMX linux 19.04
, with the package version being 1.2.7.I have attached the test data as well, which is 900 rows of stock daily OHLCV data. spce.csv
I can run through to
summary(res)
. The output fromsummary(res)
:It seems the new pull request could fix it, but I thought it's probably better to still flag it up.
Thanks Team.