google / EarlGrey

:tea: iOS UI Automation Test Framework
http://google.github.io/EarlGrey/
Apache License 2.0
5.62k stars 744 forks source link

Blacklist UICompatibilityInputViewController from being tracked above iOS 13. #1866

Closed ewannpv closed 1 year ago

ewannpv commented 1 year ago

The Apple internal API still use UICompatibilityInputViewController in iOS 16.

UICompatibilityInputViewController should also be blacklisted on iOS 13 and above.

https://github.com/google/EarlGrey/blob/17eefdcb9b94c776f12088f9372e759e6628dd51/AppFramework/Additions/UIViewController%2BGREYApp.m#L77

log:

builder: ios-simulator, os: Mac-12, test_suite: ios_chrome_ui_eg2tests_module iPhone 8 16.1
Run #1: unexpectedly failed
Logs from "failureSummaries" in .xcresult:
file: /../../ios/chrome/test/earl_grey/chrome_earl_grey.mm, line: 1455
Immediately halt execution of testcase - Couldn't assert that (base::test::ios::WaitUntilConditionOrTimeout(kWaitForActionTimeout, condition)) is true.

Timed out waiting for app to idle. 

The following idling resources are busy.

1. GREYAppStateTracker:
Waiting for viewDidAppear: call on the view controller. Please ensure that this view controller and its subclasses call through to their super's implementation.

<UICompatibilityInputViewController: 0x7f96b80ca200> => Waiting for viewDidAppear: call on the view controller. Please ensure that this view controller and its subclasses call through to their super's implementation. For more information, turn on verbose logging and rerun tests. If it's already turned on, see logs below.
ewannpv commented 1 year ago

This issue has been fixed internally, I'm closing this issue.