RequirementsWatcher is not stopped when DownloadManager is released

[ferhatparmak]

When DownloadManager.release() is called, it doesn't seem stopping RequirementsWatcher which keeps some receivers registered and that would hold DownloadManager instance. Isn't this a memory leak?

Memory profiler after release() is called on DownloadManager:

[marcbaechinger]

Thanks for reporting! This looks like a bug to me indeed!

DownloadManager.release() documents that the manager must not be accessed after this method has been called. Hence we must make sure that release cleans up the resources once acquired which includes the RequirementsWatcher that is created in the constructor (or on setRequirements(Requirements requirements) being called).

I think we need to call requirementsWatcher.stop() in DownloadManager.release() which unregisters the receivers.