google / ExoPlayer

This project is deprecated and stale. The latest ExoPlayer code is available in https://github.com/androidx/media
https://developer.android.com/media/media3/exoplayer
Apache License 2.0
21.71k stars 6.02k forks source link

bad position some character (... , !) in farsi subtitle #11214

Open sajjadshahbazi opened 1 year ago

sajjadshahbazi commented 1 year ago

Bug

I want to show Farsi subtitles, but some characters show at the beginning of the sentences. While the main sentence, those are at the end of the sentences. characters for example are: ! - ,

there is a similar issue: https://github.com/google/ExoPlayer/issues/2194 I set subView.setViewType(SubtitleView.VIEW_TYPE_WEB) for player view (I didn't use separated subtitleview, I handled subtitles in the main player) the problem was resolved. but when I use subView.setViewType(SubtitleView.VIEW_TYPE_WEB) lose focus on android tv. Apparently, the subtitle view takes focus when using subView.setViewType(SubtitleView.VIEW_TYPE_WEB).

I used BidiFormatter for testing, but I can't add some requirement parameters (language, id, and ...) and I can't test that.

sajjadshahbazi commented 1 year ago

but other characters(?) are correct position. so the problem is not related to alignment and right-to-left direction.

marcbaechinger commented 1 year ago

Can you provide us with some test media, so we can test with this?

sajjadshahbazi commented 1 year ago
            "domain": "https://mssub.namava.ir",
            "relativePath": "/files/76cdc6f8-4444-4687-aba1-9ce9a23a03b8",
            "absolutePath": "https://mssub.namava.ir/files/76cdc6f8-4444-4687-aba1-9ce9a23a03b8",
            "default": false,
            "kind": "captions",
            "label": "Farsi.srt",
            "languageCode": "per",
            "displayLabel": "فارسی"
sajjadshahbazi commented 1 year ago

our app has registration and you can't test that directly

subtitle file: per.zip

a video stream for sample: index-v1-a1.zip

sample view: Screenshot 2023-06-19 142332 Screenshot 2023-06-19 142552 Screenshot 2023-06-19 142424

icbaker commented 1 year ago

Is this issue reporting that positioning of some characters is wrong in RTL subtitles? If so I think it's a duplicate of https://github.com/google/ExoPlayer/issues/2194 as you've already linked.

Or is it reporting this:

when I use subView.setViewType(SubtitleView.VIEW_TYPE_WEB) lose focus on android tv

If it's the latter please provide complete and clear information about what 'losing focus' means in this case, and what the resulting symptoms are.

sajjadshahbazi commented 1 year ago

I continued the issue (https://github.com/google/ExoPlayer/issues/2194), but someone said please make a new issue.

my problem is the positioning of some characters is wrong in RTL subtitles and I can't use subView.setViewType(SubtitleView.VIEW_TYPE_WEB) as a solution, because I lose focus. can you give me another solution? if there isn't any solution except using subView.setViewType(SubtitleView.VIEW_TYPE_WEB), how do I resolve the problem of losing focus?

sajjadshahbazi commented 1 year ago

when starts to play on android tv, no widget in the player doesn't have focus( player controller, and any focusable view in the player), but when one time closes the player controller and again I make it show the player controller, the focus returns. But when I delete the following line : subView.setViewType(SubtitleView.VIEW_TYPE_WEB) everything is fine.

when I use subView.setViewType(SubtitleView.VIEW_TYPE_WEB) lose focus on android tv