Closed andrewger157 closed 6 years ago
andrewlewis
commented
6 years ago Please could you set DEBUG to true in ImaAdsLoader then reproduce the issue and send over the logcat output? We should be handling an empty preroll, though there's a bug where we don't handle two empty ad breaks in a row (#4030).
andrewger157
commented
6 years ago I set the debug to true in ImaAdsLoader and I have attached the Logs that I report here again
08-07 10:52:34.179 30320-30320 W/IMASDK: Invalid internal message, ignoring. Please make sure the Google IMA SDK library is up to date. Message: gmsg://afma.google.com/activityMonitor?type=getPageSignals&sid=60443a9a-1ec8-4a0c-abc9-586d33488ec1&dt=1533631954167 08-07 10:52:34.189 30320-30320 D/IMASDK: AdsManager.init -> Setting contentStartTime 3.0 08-07 10:52:35.199 30320-30320 I/ImaAdsLoader: AdEvent: {errorMessage=The response does not contain any valid ads., errorCode=1009, type=adLoadError}****
andrewlewis
commented
6 years ago Please could you provide the full logcat, not just a snippet?
andrewger157
commented
6 years ago These are the logs taken using an empty preroll and a midroll at 15 seconds
andrewlewis
commented
6 years ago I have a possible fix in review for #4030 and #4280 which will likely address this. If you provide your ad tag I can verify, or feel free to wait for an update on those issues. Marking as a duplicate for now.
andrewger157
commented
6 years ago you can try this ad tag
https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/21690435817/rplym/test/test/video&cust_params=test%3D24&optout=false&programma=La prova del cuoco&genere=lifestyle&tipologia=Programmi Tv&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&url=[referrer_url]&description_url=[description_url]&correlator=1533033741271&vid_d=300&allcues=15000
let me know thanks
andrewlewis
commented
6 years ago That ad tag plays correctly with the fix I have in review, so please look for an update on #4030 when this gets pushed to the development branch.
andrewger157
commented
6 years ago Hi, I have tested version 2.8.4 and now the player does not stop at the midroll if the preroll is empty. This is ok but the midroll is not played, if the preroll is empty / malformed none of the advs following the preroll are played. Will this behavior be fixed in the next versions?
andrewlewis
commented
6 years ago @andrewger157 I think the fix in e9e1c08 was too aggressive and caused a later ad break to be discarded. The provided ad tag plays correctly for me if I revert all of that change except the assignment pendingContentPositionMs = C.TIME_UNSET on line 1111, which is needed to ensure that the player position is reported to IMA. I've made a fix for this and it will be pushed to the dev branch soon. Thanks for following up.
Before filing an issue:
I Have searched existing issues, including issues that are closed but no luck.
When reporting a bug:
The bug occurs using the "extension-ima" library in case the call to the preroll returns an empty xml or goes into error
Issue description
Using the extension-ima library for managing the dfp advertising, if the call to the preroll returns an empty xml (or the call goes into error) all the advertisements after them (which are midroll or postroll) are not reproduced and the player remains locked at them.
Reproduction steps
to reproduce the bug with the ExoPlayer demo app it is sufficient to use an "ad_tag_url" which returns an empty preroll. If the xml also contains a midroll, the player will stop at the minute when the midroll should have started, if instead the xml contains only the postroll the player will hang on the last frame of the video content
Version of ExoPlayer being used
exoplayer:2.8.2 extension-ima:2.8.2 (also tested with version 2.7.3)
Device(s) and version(s) of Android being used
Samsung A5 Android 8.0 Samsung Galaxy s3 Neo Android 4.4.2 Huawei P8 Lite Android 7.0 Huawei P20 Android 8.1
A full bug report captured from the device
In the test I checked the traffic through Charles, and I noticed that after the call to the preroll (empty) no more calls are made for the mid / post-roll. Below is the log taken by charles https://drive.google.com/open?id=1bvobYfx3e8PC8O6baJVLjKZNBDpUYvxx
From the device, turning on the debug mode of the extensions-ima library, I have captured only the following Logs:
08-07 10:52:34.179 30320-30320 W/IMASDK: Invalid internal message, ignoring. Please make sure the Google IMA SDK library is up to date. Message: gmsg://afma.google.com/activityMonitor?type=getPageSignals&sid=60443a9a-1ec8-4a0c-abc9-586d33488ec1&dt=1533631954167 08-07 10:52:34.189 30320-30320 D/IMASDK: AdsManager.init -> Setting contentStartTime 3.0 08-07 10:52:35.199 30320-30320 I/ImaAdsLoader: AdEvent: {errorMessage=The response does not contain any valid ads., errorCode=1009, type=adLoadError}