Closed isuperqiang closed 5 years ago
I don't understand the request, since the fix for the issue you refer to is not targeted at specific devices. The fix was to always prefer the Google decoder over the MTK decoder on all devices running pre-O Android versions.
Please can you provide complete information by properly filling out the issue template, to help us investigate this further? Please copy the issue template into this issue (do not file a new one) and fill out all of the sections. Thanks!
@isuperqiang - Please update this issue.
Can't play wav file on some devices.
Set data source by local wav file, then it sounds noisy on Oppo R9tm. But plays well on other devices.
A normal wav file.
05-06 10:08:22.034 6494-7119/? I/ExoPlayerImpl: Init 25976971 [ExoPlayerLib/2.9.6] [R9, OPPO R9tm, OPPO, 22]
05-06 10:08:31.678 6494-7119/? I/ExoPlayerImpl: Release 25976971 [ExoPlayerLib/2.9.6] [R9, OPPO R9tm, OPPO, 22] [goog.exo.core]
05-06 10:08:31.703 6494-7121/? W/MessageQueue: Handler (android.os.Handler) {33d83a49} sending message to a Handler on a dead thread
java.lang.IllegalStateException: Handler (android.os.Handler) {33d83a49} sending message to a Handler on a dead thread
at android.os.MessageQueue.enqueueMessage(MessageQueue.java:356)
at android.os.Handler.enqueueMessage(Handler.java:707)
at android.os.Handler.sendMessageAtTime(Handler.java:609)
at android.os.Handler.sendMessageDelayed(Handler.java:579)
at android.os.Handler.post(Handler.java:335)
at com.google.android.exoplayer2.audio.AudioRendererEventListener$EventDispatcher.disabled(AudioRendererEventListener.java:151)
at com.google.android.exoplayer2.audio.MediaCodecAudioRenderer.onDisabled(MediaCodecAudioRenderer.java:545)
at com.google.android.exoplayer2.BaseRenderer.disable(BaseRenderer.java:153)
at com.google.android.exoplayer2.ExoPlayerImplInternal.disableRenderer(ExoPlayerImplInternal.java:976)
at com.google.android.exoplayer2.ExoPlayerImplInternal.resetInternal(ExoPlayerImplInternal.java:764)
at com.google.android.exoplayer2.ExoPlayerImplInternal.stopInternal(ExoPlayerImplInternal.java:735)
at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:312)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:224)
at android.os.HandlerThread.run(HandlerThread.java:61)
05-06 10:08:31.704 6494-7121/? W/MessageQueue: Handler (com.google.android.exoplayer2.ExoPlayerImpl$1) {12493f4e} sending message to a Handler on a dead thread
java.lang.IllegalStateException: Handler (com.google.android.exoplayer2.ExoPlayerImpl$1) {12493f4e} sending message to a Handler on a dead thread
at android.os.MessageQueue.enqueueMessage(MessageQueue.java:356)
at android.os.Handler.enqueueMessage(Handler.java:707)
at android.os.Handler.sendMessageAtTime(Handler.java:609)
at android.os.Handler.sendMessageDelayed(Handler.java:579)
at android.os.Handler.sendMessage(Handler.java:516)
at android.os.Message.sendToTarget(Message.java:429)
at com.google.android.exoplayer2.ExoPlayerImplInternal.maybeNotifyPlaybackInfoChanged(ExoPlayerImplInternal.java:387)
at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:342)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:224)
at android.os.HandlerThread.run(HandlerThread.java:61)
05-06 10:08:31.705 6494-7121/? W/MessageQueue: Handler (com.google.android.exoplayer2.ExoPlayerImpl$1) {12493f4e} sending message to a Handler on a dead thread
java.lang.IllegalStateException: Handler (com.google.android.exoplayer2.ExoPlayerImpl$1) {12493f4e} sending message to a Handler on a dead thread
at android.os.MessageQueue.enqueueMessage(MessageQueue.java:356)
at android.os.Handler.enqueueMessage(Handler.java:707)
at android.os.Handler.sendMessageAtTime(Handler.java:609)
at android.os.Handler.sendMessageDelayed(Handler.java:579)
at android.os.Handler.sendMessage(Handler.java:516)
at android.os.Message.sendToTarget(Message.java:429)
at com.google.android.exoplayer2.ExoPlayerImplInternal.maybeNotifyPlaybackInfoChanged(ExoPlayerImplInternal.java:387)
at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:342)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:224)
at android.os.HandlerThread.run(HandlerThread.java:61)
2.9.6
Oppo R9tm, Android 5.1
I fixed it by the following code. Is this OK?
public ExoMediaPlayer(Context context) {
mContext = context.getApplicationContext();
DefaultRenderersFactory renderersFactory = new DefaultRenderersFactory(context);
if (isMTKDevice()) {
renderersFactory.setMediaCodecSelector(new MediaCodecSelector() {
@Override
public List<MediaCodecInfo> getDecoderInfos(String mimeType, boolean requiresSecureDecoder) throws MediaCodecUtil.DecoderQueryException {
List<MediaCodecInfo> decoderInfos;
if (mimeType.equals(MimeTypes.AUDIO_RAW)) {
decoderInfos = new ArrayList<>(1);
MediaCodecInfo mediaCodecInfo = MediaCodecInfo.newInstance("OMX.google.raw.decoder", MimeTypes.AUDIO_RAW, null);
decoderInfos.add(mediaCodecInfo);
} else {
decoderInfos = MediaCodecUtil.getDecoderInfos(mimeType, requiresSecureDecoder);
}
return decoderInfos.isEmpty()
? Collections.emptyList()
: Collections.singletonList(decoderInfos.get(0));
}
@Nullable
@Override
public MediaCodecInfo getPassthroughDecoderInfo() throws MediaCodecUtil.DecoderQueryException {
return MediaCodecUtil.getPassthroughDecoderInfo();
}
});
}
mSimpleExoPlayer = ExoPlayerFactory.newSimpleInstance(context);
mSimpleExoPlayer.addListener(new MediaEventListener());
}
// MediaCodecUtil#isCodecUsableDecoder not handle it, so we do it
private boolean isMTKDevice() {
try {
MediaCodecInfo decoderInfo = MediaCodecUtil.getDecoderInfo(MimeTypes.AUDIO_RAW, false);
Log.i(TAG, "decoderInfo " + decoderInfo);
if (decoderInfo != null) {
return "OMX.MTK.AUDIO.DECODER.RAW".equals(decoderInfo.name);
}
} catch (MediaCodecUtil.DecoderQueryException e) {
Log.e(TAG, "isMTKDevice: ", e);
}
return false;
}
I still don't understand what this is fixing, because our code already seems to prefer OMX.google.raw.decoder
over OMX.MTK.AUDIO.DECODER.RAW
. This should happen here:
Which sorts raw decoders:
To prefer the Google decoder and explicitly de-prioritize the MTK one:
@isuperqiang - Please could you clarify why the code referenced above isn't already doing what you're trying to do? @andrewlewis - Can you spot any difference that I've missed here?
I still don't understand what this is fixing, because our code already seems to prefer
OMX.google.raw.decoder
overOMX.MTK.AUDIO.DECODER.RAW
. This should happen here:Which sorts raw decoders:
To prefer the Google decoder and explicitly de-prioritize the MTK one:
@isuperqiang - Please could you clarify why the code referenced above isn't already doing what you're trying to do? @andrewlewis - Can you spot any difference that I've missed here?
Yes, I see it. But MediaCodecUtil.getDecoderInfos
return only OMX.MTK.AUDIO.DECODER.RAW
. Your default MediaCodecSelector.DEFAULT
does not work here. I am confused.
@isuperqiang Please could you attach the output of adb shell cat /system/etc/media_codecs.xml
and adb shell cat /system/etc/media_codecs_google_audio.xml
while the device is attached? Or alternatively attach a debugger and see what's in the decoderInfos
list here. I didn't spot any issues with the code.
@andrewlewis This is media_codecs.xml
. But there is no media_codecs_google_audio.xml
.
<?xml version="1.0" encoding="utf-8" ?>
<!-- Copyright (C) 2012 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!--
<!DOCTYPE MediaCodecs [
<!ELEMENT MediaCodecs (Decoders,Encoders)>
<!ELEMENT Decoders (MediaCodec*)>
<!ELEMENT Encoders (MediaCodec*)>
<!ELEMENT MediaCodec (Type*,Quirk*)>
<!ATTLIST MediaCodec name CDATA #REQUIRED>
<!ATTLIST MediaCodec type CDATA>
<!ELEMENT Type EMPTY>
<!ATTLIST Type name CDATA #REQUIRED>
<!ELEMENT Quirk EMPTY>
<!ATTLIST Quirk name CDATA #REQUIRED>
]>
There's a simple and a complex syntax to declare the availability of a
media codec:
A codec that properly follows the OpenMax spec and therefore doesn't have any
quirks and that only supports a single content type can be declared like so:
<MediaCodec name="OMX.foo.bar" type="something/interesting" />
If a codec has quirks OR supports multiple content types, the following syntax
can be used:
<MediaCodec name="OMX.foo.bar" >
<Type name="something/interesting" />
<Type name="something/else" />
...
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Quirk name="output-buffers-are-unreadable" />
</MediaCodec>
Only the three quirks included above are recognized at this point:
"requires-allocate-on-input-ports"
must be advertised if the component does not properly support specification
of input buffers using the OMX_UseBuffer(...) API but instead requires
OMX_AllocateBuffer to be used.
"requires-allocate-on-output-ports"
must be advertised if the component does not properly support specification
of output buffers using the OMX_UseBuffer(...) API but instead requires
OMX_AllocateBuffer to be used.
"output-buffers-are-unreadable"
must be advertised if the emitted output buffers of a decoder component
are not readable, i.e. use a custom format even though abusing one of
the official OMX colorspace constants.
Clients of such decoders will not be able to access the decoded data,
naturally making the component much less useful. The only use for
a component with this quirk is to render the output to the screen.
Audio decoders MUST NOT advertise this quirk.
Video decoders that advertise this quirk must be accompanied by a
corresponding color space converter for thumbnail extraction,
matching surfaceflinger support that can render the custom format to
a texture and possibly other code, so just DON'T USE THIS QUIRK.
2012/07/13 config for MTK OMX Media Codecs, created by Morris Yang (mtk03147)
-->
<MediaCodecs>
<Decoders>
<MediaCodec name="OMX.MTK.AUDIO.DECODER.MP3" type="audio/mpeg" >
<Quirk name="decoder-lies-about-number-of-channels" />
<Quirk name="supports-multiple-frames-per-input-buffer" />
</MediaCodec>
<MediaCodec name="OMX.google.opus.decoder" type="audio/opus">
<Limit name="channel-count" max="8" />
<Limit name="sample-rate" ranges="8000-96000" />
<Limit name="bitrate" range="1-10000000" />
</MediaCodec>
<MediaCodec name="OMX.MTK.AUDIO.DECODER.ADPCM.MS" type="audio/x-adpcm-ms" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.ADPCM.DVI" type="audio/x-adpcm-dvi-ima" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.GSM" type="audio/gsm" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.RAW" type="audio/raw" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.G711.ALAW" type="audio/g711-alaw" >
<Quirk name="decoder-lies-about-number-of-channels" />
</MediaCodec>
<MediaCodec name="OMX.MTK.AUDIO.DECODER.G711.MLAW" type="audio/g711-mlaw" >
<Quirk name="decoder-lies-about-number-of-channels" />
</MediaCodec>
<MediaCodec name="OMX.MTK.AUDIO.DECODER.FLAC" type="audio/flac" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.WMA" type="audio/x-ms-wma" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.WMAPRO" type="audio/x-ms-wmapro" />
<MediaCodec name="OMX.MTK.AUDIO.DECODER.APE" type="audio/ape" >
<Quirk name="decoder-lies-about-number-of-channels" />
<Quirk name="supports-multiple-frames-per-input-buffer" />
</MediaCodec>
<MediaCodec name="OMX.MTK.AUDIO.DECODER.ALAC" type="audio/alac" />
<MediaCodec name="OMX.MTK.VIDEO.DECODER.MPEG2" type="video/mpeg2" >
<Limit name="size" min="16x16" max="1920x1088" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.HEVC" type="video/hevc" >
<Limit name="size" min="16x16" max="1920x1088" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Feature name="adaptive-playback"/>
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.MPEG4" type="video/mp4v-es" >
<Limit name="size" min="16x16" max="1920x1088" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Feature name="adaptive-playback"/>
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.H263" type="video/3gpp" >
<Limit name="size" min="128x96" max="1408x1152" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Feature name="adaptive-playback"/>
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.AVC" type="video/avc" >
<Limit name="size" min="64x64" max="1920x1088" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Feature name="adaptive-playback"/>
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.VPX" type="video/x-vnd.on2.vp8" >
<Limit name="size" min="16x16" max="1920x1088" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Feature name="adaptive-playback"/>
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.VP9" type="video/x-vnd.on2.vp9" >
<Limit name="size" min="16x16" max="1920x1088" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Feature name="adaptive-playback"/>
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.VC1" type="video/x-ms-wmv" >
<Limit name="size" min="16x16" max="1920x1088" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.DIVX" type="video/divx" >
<Limit name="size" min="16x16" max="1920x1088" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.DIVX3" type="video/divx3" >
<Limit name="size" min="16x16" max="1920x1088" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.XVID" type="video/xvid" >
<Limit name="size" min="16x16" max="1920x1088" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.DECODER.S263" type="video/flv1" >
<Limit name="size" min="16x16" max="1920x1088" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.google.vp8.decoder" type="video/x-vnd.on2.vp8">
<Limit name="size" min="2x2" max="1920x1088" />
<Limit name="alignment" value="2x2" />
<Limit name="block-size" value="16x16" />
<Limit name="blocks-per-second" range="1-1000000" />
<Limit name="bitrate" range="1-40000000" />
<Feature name="adaptive-playback" />
</MediaCodec>
<MediaCodec name="OMX.google.h264.decoder" type="video/avc">
<!-- profiles and levels: ProfileBaseline : Level51 -->
<Limit name="size" min="2x2" max="1920x1088" />
<Limit name="alignment" value="2x2" />
<Limit name="block-size" value="16x16" />
<Limit name="blocks-per-second" range="1-983040" />
<Limit name="bitrate" range="1-40000000" />
<Feature name="adaptive-playback" />
</MediaCodec>
<MediaCodec name="OMX.google.amrnb.decoder" type="audio/3gpp" />
<MediaCodec name="OMX.google.amrwb.decoder" type="audio/amr-wb" />
<MediaCodec name="OMX.google.aac.decoder" type="audio/mp4a-latm" />
<MediaCodec name="OMX.google.vorbis.decoder" type="audio/vorbis" />
<!-- DOLBY_UDC -->
<MediaCodec name="OMX.dolby.ac3.decoder" >
<Type name="audio/ac3" />
<Quirk name="needs-flush-before-disable" />
<Quirk name="requires-flush-complete-emulation" />
</MediaCodec>
<MediaCodec name="OMX.dolby.ec3.decoder" >
<Type name="audio/eac3" />
<Quirk name="needs-flush-before-disable" />
<Quirk name="requires-flush-complete-emulation" />
</MediaCodec>
<!-- DOLBY_UDC END -->
</Decoders>
<Encoders>
<MediaCodec name="OMX.MTK.VIDEO.ENCODER.MPEG4" type="video/mp4v-es" >
<Limit name="size" min="176x144" max="176x144" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.ENCODER.H263" type="video/3gpp" >
<Limit name="size" min="176x144" max="176x144" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.ENCODER.AVC" type="video/avc" >
<Limit name="size" min="128x96" max="1920x1080" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
</MediaCodec>
<MediaCodec name="OMX.MTK.VIDEO.ENCODER.VPX" type="video/x-vnd.on2.vp8" >
<Limit name="size" min="64x64" max="1280x720" />
<Limit name="alignment" value="16x16" />
<Limit name="block-size" value="16x16" />
<Quirk name="requires-allocate-on-input-ports" />
<Quirk name="requires-allocate-on-output-ports" />
<Quirk name="avoid-memcpy-input-recording-frames" />
</MediaCodec>
<MediaCodec name="OMX.MTK.AUDIO.ENCODER.VORBIS" type="audio/vorbis" />
<MediaCodec name="OMX.MTK.AUDIO.ENCODER.ADPCM.MS" type="audio/x-adpcm-ms" />
<MediaCodec name="OMX.MTK.AUDIO.ENCODER.ADPCM.DVI" type="audio/x-adpcm-dvi-ima" />
<MediaCodec name="OMX.google.aac.encoder" type="audio/mp4a-latm" />
<MediaCodec name="OMX.google.amrnb.encoder" type="audio/3gpp" />
<MediaCodec name="OMX.google.amrwb.encoder" type="audio/amr-wb" />
<MediaCodec name="OMX.google.flac.encoder" type="audio/flac" />
<MediaCodec name="OMX.google.vp8.encoder" type="video/x-vnd.on2.vp8">
<!-- profiles and levels: ProfileMain : Level_Version0-3 -->
<Limit name="size" min="2x2" max="1280x720" />
<Limit name="alignment" value="2x2" />
<Limit name="bitrate" range="1-40000000" />
<Feature name="bitrate-modes" value="VBR,CBR" />
</MediaCodec>
</Encoders>
</MediaCodecs>
See previous issue, I found Oppo R9(Android 5.1) is MTK device, so please add it to MediaCodecUtil#isCodecUsableDecoder(). Thanks.