search

google / ExoPlayer

This project is deprecated and stale. The latest ExoPlayer code is available in https://github.com/androidx/media
https://developer.android.com/media/media3/exoplayer
Apache License 2.0
21.74k stars 6.03k forks source link

Display ad markers when using the Leanback UI via ExoPlayer's Leanback extension #6695

Open SakthivelMuruganS opened 4 years ago

SakthivelMuruganS commented 4 years ago

I want to display markers for ads in Exoplayer using the Leanback Adapter and Glue. I've used Player Adapter & PlaybackTransportControlGlue (androidx.leanback.media) to stream the content. I'm able to load ads using Ima ads Loader in the video but I want to show the ad marker in lean-back seek bar like Exo player default time bar for different types of ad roll (pre-roll, mid-roll & post-roll).

ojw28 commented 4 years ago

I don't think the leanback library supports ad markers (else there would be a way to expose them here). So I think your options are to file a feature request here, or build your own player controls UI instead.

If you do file a feature request, please let us know (by replying here). I'd be interested to follow/nudge it along, since this seems like a fairly basic shortcoming of the leanback UI.

ojw28 commented 4 years ago

Marking this as "needs for information", because you'll need to file a feature request on the leanback library asking them to support ad markers. Without that, this issue is blocked on a feature request in another library that no one has requested.

Please respond here with a link to the leanback feature request if you make one. Else this issue will be automatically closed.

SakthivelMuruganS commented 4 years ago

I've filed a feature request and please find the feature request link in below https://github.com/google/ExoPlayer/issues/6789

Kindly let us know the update on this. Thank you.

ojw28 commented 4 years ago

You need to file a feature request on the Leanback Library, not on ExoPlayer. As in my initial response, you should do this here.

SakthivelMuruganS commented 4 years ago

Can you tell me what is the component in feature request option??

ojw28 commented 4 years ago

The link should already take you to the right component (componentid:460758). You can click the drop arrow on the "create issue" button and click "in same component".

SakthivelMuruganS commented 4 years ago

Yes I've filed a request in this and Thanks for your kind support

ojw28 commented 4 years ago

Leanback feature request: http://issuetracker.google.com/issues/146537025