Closed fountaingeyser closed 3 years ago
Agree there is an issue here. It looks like the padding of exo_center_controls
is not being removed from the calculation, which I think it should be. There's also a problem horizontally where the edges of the far left/right icons can end up being clipped even when there is sufficient space for them to be fully rendered.
With the introduction of the minimal mode the player controls become mostly unusable in many cases. When used in portrait mode on the OnePlus 7 with a 16:9 video the minimal mode is already activated. Consequently, none of the basic controls (e.g. VR or shuffle button) are reachable for users anymore.
A thorough investigation has revealed that the height of the player is considered too small to fit the default control views: https://github.com/google/ExoPlayer/blob/4364b9150f236813a2070fc79d3bcb76e11969ac/library/ui/src/main/java/com/google/android/exoplayer2/ui/StyledPlayerControlViewLayoutManager.java#L565-L589
Two possible solutions are: