search

google / GTMAppAuth

Apple platforms SDK for using AppAuth with Google libraries.
Apache License 2.0
379 stars 198 forks source link

Add keychain support to `GTMAppAuthFetcherAuthorization.swift` #162

Closed mdmathias closed 2 years ago

mdmathias commented 2 years ago

@petea and @Alex-4-Git I wanted to point out that I bumped our base macOS support to 10.13.

This is so we can use keychain methods like this in Swift.

petea commented 2 years ago

@petea and @Alex-4-Git I wanted to point out that I bumped our base macOS support to 10.13.

This is so we can use keychain methods like this in Swift.

Do you mean NSKeyed(Archiver | Unarchiver) methods? Would this not be an issue for iOS as well?

mdmathias commented 2 years ago

@petea Yes, sorry for the confusion. I'm talking about NSKeyedUnarchiver.unarchivedObject(ofClass: from:). And yes, this is also an issue for iOS and tvOS, as that method is available for iOS 11 and tvOS 11 and up. I surprised that Xcode didn't flag that for me. :/

mdmathias commented 2 years ago

I've resolved the issue with NSKeyedUnarchiver.unarchivedObject(ofClass: from:) with availability checks.