Add a method taking a completion argument for asynchronous error updates

google / GTMAppAuth

Apple platforms SDK for using AppAuth with Google libraries.

Apache License 2.0

379 stars 198 forks source link

Add a method taking a completion argument for asynchronous error updates #229

Closed mdmathias closed 1 year ago

mdmathias commented 1 year ago

This change adds a completion argument for handling updated errors in EMM flow (e.g., https://github.com/google/GoogleSignIn-iOS/pull/299).

mdmathias commented 1 year ago

One potential issue here that we may want to consider is that fetcherService.callbackQueue could potentially be DispatchQueue.main, which I believe would cause problems in this implementation. If that is the case, perhaps we may need to always use our own queue.

https://github.com/google/GTMAppAuth/pull/229/files#diff-89da9dc9b967ff6b4c2f04d9775c20289edc2b2668c8e628c922e8d2f534cc68R288

@ch40w31 thoughts?

mdmathias commented 1 year ago

Please disregard https://github.com/google/GTMAppAuth/pull/229#issuecomment-1518771236. Took a direction that should avoid the problem.