search

google / GTMAppAuth

Apple platforms SDK for using AppAuth with Google libraries.
Apache License 2.0
379 stars 198 forks source link

Fix keychain key bug #237

Closed mdmathias closed 10 months ago

mdmathias commented 10 months ago

This PR addresses a bug where the key attributes used to query the keychain were not being added correctly, and where therefore unused. The mistake was that the key names were assumed to match the static constants.

Fixes #236.

mdmathias commented 10 months ago

Hi @olvrlrnz please take a look and help us to make sure that this change meets the need. Thanks!

olvrlrnz commented 10 months ago

Just tried it in our code base, LGTM image

mdmathias commented 10 months ago

@olvrlrnz Sorry for bugging you again, but I made some changes since you last looked. Would you mind double checking for me? 🙏

olvrlrnz commented 9 months ago

Thanks for fixing this. Would it be possible to create a 4.0.1 release so we can update the package in Xcode?

mdmathias commented 9 months ago

Absolutely. We need to figure out what version we call this. In any case, we will be making a new release to include a privacy manifest very shortly. I think that will come out in the next few weeks. Stay tuned for that, and sorry for the delay.