search

google / GTMAppAuth

Apple platforms SDK for using AppAuth with Google libraries.
Apache License 2.0
379 stars 198 forks source link

KeychainAttribute: Return correct names of keychain attributes #238

Closed olvrlrnz closed 10 months ago

olvrlrnz commented 10 months ago

This commit fixes issue google/GTMAppAuth#236: KeychainAttribute.keyName should not return the quoted constants but rather the Foundation constants itself -- e.g. kSecUseDataProtectionKeychain instead of "kSecUseDataProtectionKeychain". KeychainWrapper uses the return value as-is to assemble the query dictionary for SecItem(Add|Delete|CopyMatching). Therefore, using the wrong property names means the attributes never had any effect.

google-cla[bot] commented 10 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.