search

google / GiftStick

1-Click push forensics evidence to the cloud
Apache License 2.0
137 stars 21 forks source link

Change Stackdriver logging source #100

Closed jonathan-greig closed 4 years ago

jonathan-greig commented 4 years ago

Currently when Stackdriver logging is enabled, rather than logging what is explicitly logged with AutoForensicate's logger, it captures logging produced by all Python modules by registering as a handler for the root Python logger.

This appears to be causing issue #99 where output is duplicated on the local console when Stackdriver logging is enabled.

The proposed change will configure Stackdriver logging to only capture what is explicitly logged wtih AutoForensicate's logger. Resolves #99

codecov-commenter commented 4 years ago

Codecov Report

Merging #100 into master will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   81.48%   81.47%   -0.02%     
==========================================
  Files          22       22              
  Lines        1388     1387       -1     
==========================================
- Hits         1131     1130       -1     
  Misses        257      257
Impacted Files Coverage Δ
auto_forensicate/auto_acquire.py 61.45% <0.00%> (-0.22%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91b9afd...f4af470. Read the comment docs.