search

google / GiftStick

1-Click push forensics evidence to the cloud
Apache License 2.0
137 stars 21 forks source link

Mark firmware recipe as optional #107

Closed rgayon closed 4 years ago

rgayon commented 4 years ago

After fixing error reporting, the firmware acquisition recipe fails on E2E tests (due to them running on QEMU). This marks the whole upload as failed, which marks the test as failed.

We're setting a new option for the ProcessOutputRecipe to not raise (but log an error)

codecov-commenter commented 4 years ago

Codecov Report

Merging #107 into master will decrease coverage by 0.04%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   82.17%   82.13%   -0.05%     
==========================================
  Files          22       22              
  Lines        1470     1472       +2     
==========================================
+ Hits         1208     1209       +1     
- Misses        262      263       +1
Impacted Files Coverage Δ
auto_forensicate/recipes/firmware.py 81.81% <ø> (ø)
auto_forensicate/recipes/base.py 88.03% <50.00%> (-0.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc82d15...ecdc1e1. Read the comment docs.