Change AskDiskList to present only the disks that is not the one to boot GiftStick

google / GiftStick

1-Click push forensics evidence to the cloud

Apache License 2.0

137 stars 21 forks source link

Change AskDiskList to present only the disks that is not the one to boot GiftStick #135

Closed rgayon closed 1 year ago

rgayon commented 1 year ago

https://github.com/google/GiftStick/blob/21dc5db04798c3d2262c8847be54e7fb955792ef/auto_forensicate/ux/gui.py#L38

rgayon commented 1 year ago

Maybe consider "hiding" anything that is mounted?

michalp1234 commented 1 year ago

I like that idea as it hides the source drive as well

rgayon commented 1 year ago

When runnin in "auto" mode we already ignore anything connected to USB to really only copy disks that are "attached" to the machine (see _IsUsb() in recipe/disk.py)

When the user specifies --select_disks, I expect them to know which one they want. They are already presented with the model name.

I'm adding a new PR to detect whether the disk has a partition that is mounted, and also let the user know about it