Is your feature request related to a problem you're having? Please describe.
Per a comment on this PR, it was noted that we are not able to use a memberwise initializer in GIDSignIn to pass in an instance of GIDAppCheck. Therefore, we use a private initializer in tests to pass in an instance of GIDAppCheck. Thus, GIDSignIn needed a way in the configure method to check if there is already an instance of GIDAppCheck. If there is, do nothing; otherwise, make the default instance (i.e., one not for tests).
Describe the solution you'd likeGIDSignIn shouldn't be a singleton. Once that is the case, we can pass in whatever we like in the initializer.
mdmathias
commented
1 year ago
Is your feature request related to a problem you're having? Please describe. Per a comment on this PR, it was noted that we are not able to use a memberwise initializer in
GIDSignInto pass in an instance ofGIDAppCheck. Therefore, we use a private initializer in tests to pass in an instance ofGIDAppCheck. Thus,GIDSignInneeded a way in the configure method to check if there is already an instance ofGIDAppCheck. If there is, do nothing; otherwise, make the default instance (i.e., one not for tests).Describe the solution you'd like
GIDSignInshouldn't be a singleton. Once that is the case, we can pass in whatever we like in the initializer.