search

google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
478 stars 194 forks source link

Add HttpFetcher component #328

Open henryhl22321 opened 1 year ago

henryhl22321 commented 1 year ago

Add class HttpFetcher fetches data from URL endpoint. Add the FakeHttpFetcher. Use HttpFetcher on GIDSignIn for revoking the grant scope.

mdmathias commented 1 year ago

Hey @henryhl22321 it looks like you have some linting failiures:

- ERROR | xcodebuild:  /Users/runner/work/GoogleSignIn-iOS/GoogleSignIn-iOS/GoogleSignIn/Tests/Unit/GIDHTTPFetcherTest.m:48:3: error: declaration of 'GTMSessionFetcherTestBlock' must be imported from module 'GTMSessionFetcher.GTMSessionFetcher' before it is required

You may be able to diagnose these failures more quickly by running pod lib lint GoogleSignIn.podspec locally before sending up your PR for review.