google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
478 stars 194 forks source link

Finalize and replace app check loading logic in -[GIDSignIn authorizationRequestWithOptions:completion:]` #329

Closed mdmathias closed 10 months ago

mdmathias commented 1 year ago

The current implementation dispatches async after waiting 1/2 second to ensure that an activity spinner is displayed to avoid flashing. We should update the logic to instead do the following:

  1. If the call to app check completes before some short threshold is met, just carry on without any loading screen.
  2. If that threshold is exceeded, then display a loading screen for at least 1/2 second.
  3. After displaying the loading screen for 1/2, complete when callback is received from app check.
mdmathias commented 10 months ago

Resolving as addressed by #331