google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
506 stars 201 forks source link

Do not modally animate the presenting of app check loading UI #340

Closed mdmathias closed 1 year ago

mdmathias commented 1 year ago

This PR updates the presentation of the loading UI when it takes more than 0.5 seconds to load the token. Previously, we would modally present a view controller with an activity indicator. That animation was awkward because it would pop the presenting view controller backwards, and overlay the loading UI. The updated presentation avoids that animation, and overlays a transparent gray view over the presenting view controller's view.

Before: https://github.com/google/GoogleSignIn-iOS/assets/4029922/ff8ede7b-118c-422b-94fa-0eb4c9a6b6b1 After: https://github.com/google/GoogleSignIn-iOS/assets/4029922/6eff3f98-09cb-4ade-84cc-1c30383dfa8c