google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
478 stars 194 forks source link

Support App Privacy Manifest #341

Closed devssun closed 5 months ago

devssun commented 11 months ago

Is your feature request related to a problem you're having? Please describe. Apple required App Privacy manifests until 2025. So GoogleSignIn-iOS SDK that contains an app privacy manifest must be signed. I would like to know when you adopt this change.

References https://developer.apple.com/videos/play/wwdc2023/10060/ https://developer.apple.com/news/?id=av1nevon https://developer.apple.com/app-store/user-privacy-and-data-use/

Please check it out. Thanks!

Describe the solution you'd like Add Privacy Manifest

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

mdmathias commented 11 months ago

Thanks for the issue. We are tracking this internally and will address it in the Fall.

devssun commented 11 months ago

Thank you for your comment.

mdmathias commented 8 months ago

Wanted to post an update: we are planning to include add a privacy manifest prior to Apple's Spring 2024 deadline.

lakshmankreditbee commented 8 months ago

Hi, when can we expect an update regarding this issue?

mdmathias commented 7 months ago

We do not have an exact date planned for a new release that will add this manifest, but per my last message here, we will get this done prior to Apple's Spring 2024 deadline.

mejim707 commented 7 months ago

Hi, is there an update for timing on this release? We only have about 1.5 months before April and will need time to implement, resolve any potential breaking changes, and get sign off on this new release.

Thanks

mdmathias commented 7 months ago

Hi @mejim707 we are actively working on this, but we do not have a specific date to share. We do understand that folks depending upon GSI will need time, and are working as quickly as we can. Please stay tuned as we will be updating here as soon as possible.

mejim707 commented 7 months ago

Thank you sir!

batikansosun commented 6 months ago

Hi @mdmathias,

Would you please let me know if there has been any progress on this?

mdmathias commented 6 months ago

We will be adding the privacy manifest and making a release in a couple of weeks, which should give developers time before the May 1st date posted by Apple.

Mcrich23 commented 5 months ago

I noticed that the latest changes in Main support GTMAppAuth 4.0.0 which has a manifest, but the current release (7.0.0) does not. Can you please provide insight into when those changes will be released?

ywsang commented 5 months ago

We are actively working on prepping a new release that will update dependencies to versions that include a privacy manifest, as well as add a privacy manifest for GSI itself.

mejim707 commented 5 months ago

@ywsang I see this is closed now but I don't see a new release. Has a release been made which includes the Privacy Manifest update?

ywsang commented 5 months ago

@mejim707 Not quite yet, but we're working on getting a new release that includes the Privacy Manifest update soon.

SeongWook-Jo commented 5 months ago

@ywsang If the issue is resolved, will Unity samples also be provided?

ywsang commented 5 months ago

@SeongWook-Jo This issue is resolved and the release that includes in the Privacy Manifest has been made (7.1.0). We don't have any actively maintained Unity samples (our existing samples written in Swift and iOS can be found here), and there are no plans to create a new set of Unity sample projects.

Mcrich23 commented 5 months ago

Also, this isn't something that devs have to touch other than updating the version

SeongWook-Jo commented 5 months ago

@ywsang Here, there's a sample provided previously for Unity. However, it's not being updated currently. As a result, many Unity developers might be experiencing difficulties. Is there an effective way to import that SDK into Unity?

adorum commented 5 months ago

@vonovak regarding react-native-google-signin/google-signin#1265 release GoogleSignIn-iOS 7.1.0 is already out.

mdmathias commented 5 months ago

@SeongWook-Jo We do not own those samples and do not have the expertise to update them. Perhaps you can reach out to that repo and make a request to update them there?