search

google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
478 stars 194 forks source link

macOS build warning fix #342

Open msanford-class opened 11 months ago

msanford-class commented 11 months ago

The umbrella header file,GoogleSignIn.h, contains #if TARGET_OS_IOS || TARGET_OS_MACCATALYST causes an Xcode build warning for macOS builds. This #if here is not needed given the underlying header file, GIDSignInButton.h already has this identical compiler conditional. Removing this #if in the umbrella header removes the macOS build warning and still continues to build successfully for iOS and Mac Catalyst.

google-cla[bot] commented 11 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.