search

google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
478 stars 194 forks source link

Running pod install for SignInSample produces warning in Google Sign-In 7.1.0-fac-eap-1.0.0 #354

Closed mdmathias closed 9 months ago

mdmathias commented 9 months ago

Describe the bug

After checking out the fac-eap branch, running pod install within the SignInSample/ directory produces the warning below (after running successfully).

[!] The platform of the target `SampleForPod` (iOS 10.0) may not be compatible with `AppCheckCore (10.18.0)` which has a minimum requirement of iOS 11.0 - macOS 10.13 - tvOS 12.0 - watchOS 6.0.

[!] The platform of the target `SampleForPod` (iOS 10.0) may not be compatible with `GoogleSignIn (7.1.0-fac-eap-1.0.0)` which has a minimum requirement of iOS 11.0 - macOS 10.15.

[!] The platform of the target `SampleForPod` (iOS 10.0) may not be compatible with `GoogleSignIn/unit (7.1.0-fac-eap-1.0.0)` which has a minimum requirement of iOS 11.0 - macOS 10.15.

The issue stems from the fact that the sample app's Podfile lists its minimum iOS version as 10.0 while GoogleSignIn.podspec lists 11.0 as the minimum iOS version.

To Reproduce

  1. Check out the fac-eap branch.
  2. From the root of the repo, cd Samples/ObjC/SignInSample
  3. Run pod install

Expected behavior

No such warning.

Remedy

The fix is to bump the minimum iOS version in SignInSample's Podfile to be 11.0.